Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce JS size by 60% #26

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Reduce JS size by 60% #26

merged 1 commit into from
Oct 9, 2023

Conversation

jeremystucki
Copy link
Member

Before After
Uncompressed 1,495.31 kB 296.91 kB
Compressed 546.66 kB 102.19 kB

Closes #24

@jeremystucki jeremystucki self-assigned this Oct 1, 2023
@jeremystucki jeremystucki added this pull request to the merge queue Oct 9, 2023
@jeremystucki jeremystucki removed this pull request from the merge queue due to a manual request Oct 9, 2023
@jeremystucki
Copy link
Member Author

I'll merge it after the current enrollment phase.

@jeremystucki
Copy link
Member Author

Nevermind, how bad can it be?

@jeremystucki jeremystucki added this pull request to the merge queue Oct 9, 2023
Merged via the queue into main with commit 9dbd843 Oct 9, 2023
2 checks passed
@jeremystucki jeremystucki deleted the remove-fontawesome-imports branch October 9, 2023 06:38
@jeremystucki jeremystucki mentioned this pull request Nov 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mafii Mafii Mafii approved these changes

@StefanieJaeger StefanieJaeger Awaiting requested review from StefanieJaeger

Assignees

@jeremystucki jeremystucki

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Investigate why our javascript is 1.5MB
2 participants
@jeremystucki @Mafii